You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add ability to configure SQL parser dialect in SessionState - #23235
It's still a bit inconsistent, because it doesn't follow what is set at the config level (see issue), but I guess better than nothing?
What do you mean? That it's not possible to set a custom SQL dialect from a string name, e.g. SET datafusion.sql_parser.dialect = 'custom'? If so this seems like a non-issue to me. There's plenty of dyn APIs that are not configurable from SQL, I'd consider this a pretty advanced usage of DataFusion.
What does the config return once you set a custom dialect using these APIs (SHOW datafusion.sql_parser.dialect;)?
What do you mean? That it's not possible to set a custom SQL dialect from a string name, e.g. SET datafusion.sql_parser.dialect = 'custom'? If so this seems like a non-issue to me. There's plenty of dyn APIs that are not configurable from SQL, I'd consider this a pretty advanced usage of DataFusion.
Makes sense, most likely it makes sense for users using this API to make sure they set their datafusion.sql_parser.dialect config to a custom value like 'my_custom_dialect' or something, but actually I'm wondering if this is possible right now, as the config only allows a fixed set of values.
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreCore DataFusion crateStalePR has not had any activity for some time
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Fixes #23109.
Rationale for this change
What changes are included in this PR?
This is one approach that tries solving #23109, by allowing the SQL parser dialect to be configured at the
SessionStatelevel.It's still a bit inconsistent, because it doesn't follow what is set at the config level (see issue), but I guess better than nothing?
Are these changes tested?
Yes.
Are there any user-facing changes?
No.