Repository navigation
Remove Parquet Empty Projection Workaround - #2289
Merged
Merged
Conversation
Contributor
Author
|
The CI failure appears to be reproducible but isn't in a component I've modified... I am rather confused, will come back to tomorrow... If someone could provide some pointers that would be amazing 😅 |
yjshen
approved these changes
Apr 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #1999
Rationale for this change
#2000 added a workaround to special-case empty projections, this has since been fixed upstream with apache/arrow-rs#1537 and so we can remove this code
What changes are included in this PR?
Removes custom empty projection logic
Are there any user-facing changes?
No
FYI @pjmore