Repository navigation
subquery rfc - #1492
Closed
xudong963 wants to merge 1 commit into
Closed
subquery rfc#1492xudong963 wants to merge 1 commit into
xudong963 wants to merge 1 commit into
Conversation
Dandandan
reviewed
Dec 27, 2021
xudong963
force-pushed
the
subquery_rfc
branch
from
December 27, 2021 16:12
c9771f7 to
6f4b9f3
Compare
hntd187
reviewed
Dec 27, 2021
| Let's turn our attention to Datafusion. | ||
|
|
||
| There are two overall steps: | ||
| 1. transfer sqlparser subquery exprs to datafusion exprs. |
Contributor
There was a problem hiding this comment.
Do you mean something like an Into<Expr> impl or something of the sort on the datafusion side?
Member
Author
There was a problem hiding this comment.
sql_expr_to_logical_expr function in datafusion/src/sql/planner.rs
Contributor
|
Marking PRs without activity in the last month as stale. I'll plan to close it in another month or so without activity, though feel free to reopen it when you have time to work on it) |
Contributor
|
Closing stale PRs. Please reopen (or open a new one) if you plan to keep working on this feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?