Skip to content

subquery rfc - #1492

Closed
xudong963 wants to merge 1 commit into
apache:masterfrom
xudong963:subquery_rfc
Closed

xudong963 wants to merge 1 commit into
apache:masterfrom
xudong963:subquery_rfc

Conversation

@xudong963

Copy link
Copy Markdown
Member

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

Comment thread docs/rfcs/subquery_design.md Resolved
Comment thread docs/rfcs/subquery_design.md Resolved
Comment thread docs/rfcs/subquery_design.md Resolved
Comment thread docs/rfcs/subquery_design.md Resolved
Let's turn our attention to Datafusion.

There are two overall steps:
1. transfer sqlparser subquery exprs to datafusion exprs.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean something like an Into<Expr> impl or something of the sort on the datafusion side?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sql_expr_to_logical_expr function in datafusion/src/sql/planner.rs

@alamb

alamb commented Jan 31, 2022

Copy link
Copy Markdown
Contributor

Marking PRs without activity in the last month as stale. I'll plan to close it in another month or so without activity, though feel free to reopen it when you have time to work on it)

@alamb

alamb commented Feb 15, 2022

Copy link
Copy Markdown
Contributor

Closing stale PRs. Please reopen (or open a new one) if you plan to keep working on this feature.

@alamb alamb closed this Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants