Skip to content

Skip target in taplo checks - #14747

Merged
findepi merged 1 commit into
apache:mainfrom
findepi:findepi/skip-target-in-taplo-checks-b14cff
Feb 18, 2025
Merged

findepi merged 1 commit into
apache:mainfrom
findepi:findepi/skip-target-in-taplo-checks-b14cff

Conversation

@findepi

@findepi findepi commented Feb 18, 2025

Copy link
Copy Markdown
Member

target can contain arbitrary files. Contents depend on tools used and tests run, and may even include Cargo.toml files that are not properly formatted. The taplo check should never complain on files that are not meant to be part of the repository, and target contents clearly falls into that category.

trybuild is an example of a tool that creates cargo files inside target directory.

`target` can contain arbitrary files. Contents depend on tools used and
tests run, and may even include `Cargo.toml` files that are not properly
formatted. The taplo check should never complain on files that are not
meant to be part of the repository, and `target` contents clearly falls
into that category.

`trybuild` is an example of a tool that creates cargo files inside
target directory.
@findepi

findepi commented Feb 18, 2025

Copy link
Copy Markdown
Member Author

trybuild is an example of a tool that creates cargo files inside target directory.

BTW i am using trybuild in #14668, so this will become necessary change there

@findepi
findepi merged commit ed517ef into apache:main Feb 18, 2025
@findepi
findepi deleted the findepi/skip-target-in-taplo-checks-b14cff branch February 18, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants