Skip to content

Remove unnecessary Result from return type in NamePreserver - #12358

Merged
Dandandan merged 1 commit into
apache:mainfrom
jonahgao:remove_result
Sep 7, 2024
Merged

Dandandan merged 1 commit into
apache:mainfrom
jonahgao:remove_result

Conversation

@jonahgao

@jonahgao jonahgao commented Sep 6, 2024

Copy link
Copy Markdown
Member

Which issue does this PR close?

Follow up of #12341

Rationale for this change

The save and restore functions always return OK, so the Result return type becomes redundant.

What changes are included in this PR?

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions github-actions Bot added logical-expr Logical plan and expressions optimizer Optimizer rules labels Sep 6, 2024

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice improvement to me -- thank you @jonahgao

@Jefffrey Jefffrey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

Should this be tagged with api change since technically NamePreserver and SavedName are technically exposed in the public API?

@alamb alamb added the api change Changes the API exposed to users of the crate label Sep 6, 2024
@alamb

alamb commented Sep 6, 2024

Copy link
Copy Markdown
Contributor

Makes sense to me.

Should this be tagged with api change since technically NamePreserver and SavedName are technically exposed in the public API?

I think you are right -- done!

@Dandandan
Dandandan merged commit 453c026 into apache:main Sep 7, 2024
@jonahgao
jonahgao deleted the remove_result branch September 7, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api change Changes the API exposed to users of the crate logical-expr Logical plan and expressions optimizer Optimizer rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants