Skip to content

Minor: avoid a clone in type coercion - #11530

Merged
alamb merged 2 commits into
apache:mainfrom
alamb:alamb/one_less_clone
Jul 18, 2024
Merged

alamb merged 2 commits into
apache:mainfrom
alamb:alamb/one_less_clone

Conversation

@alamb

@alamb alamb commented Jul 18, 2024

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Follow on to #11491 from @xinlifoobar

Rationale for this change

While reviewing #11491 I found a way to remove the clone of predicate in the type coercion pass

What changes are included in this PR?

  1. Remove a clone
  2. Add a test for the nice error message on non boolean predicates

Are these changes tested?

yes

Are there any user-facing changes?

no

@github-actions github-actions Bot added optimizer Optimizer rules sqllogictest SQL Logic Tests (.slt) labels Jul 18, 2024
@alamb
alamb marked this pull request as ready for review July 18, 2024 09:54
@alamb
alamb marked this pull request as draft July 18, 2024 12:08

@jayzhan211 jayzhan211 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alamb
alamb marked this pull request as ready for review July 18, 2024 18:35
@alamb
alamb merged commit 723a595 into apache:main Jul 18, 2024
Lordworms pushed a commit to Lordworms/arrow-datafusion that referenced this pull request Jul 23, 2024
* Minor: avoid a clone in type coercion

* Fix test
wiedld pushed a commit to influxdata/arrow-datafusion that referenced this pull request Jul 31, 2024
* Minor: avoid a clone in type coercion

* Fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

optimizer Optimizer rules sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants