You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
// This function specifies monotonicity behaviors for User defined scalar functions.fnmonotonicity(&self) -> Result<Option<Vec<Option<bool>>>,DataFusionError>{..}
The challenge is the cognative complexity of understanding what Result<Option<Vec<Option<bool>>> means
However, since it is a typedef it doesn't show up in the Rust docs
Describe the solution you'd like
An easy to understand Monotonicity API
Describe alternatives you've considered
I think it would be great to have an API like this:
// This function specifies monotonicity behaviors for User defined scalar functions.fnmonotonicity(&self) -> Result<Monotonicity>,DataFusionError> {..}
And then we could make Monotonicity an enum that captured the relevant data. This would both be easier to understand and likely more efficient as well
Something like
/// Monotonicity of a function with respect to its arguments.////// A function is [monotonic] if it preserves the relative order of its inputs. ////// [monotonic]: https://en.wikipedia.org/wiki/Monotonic_functionpubenumMonotonicity{/// not monotonic or unknown monotonicityNone,/// Increasing with respect to all of its argumentsIncreasing,/// Decreasing with respect to all of its argumentsDecreasing,/// Each element of this vector corresponds to an argument and indicates whether/// the function's behavior is monotonic, or non-monotonic/unknown for that argument, namely:/// - `None` signifies unknown monotonicity or non-monotonicity./// - `Some(true)` indicates that the function is monotonically increasing w.r.t. the argument in question./// - Some(false) indicates that the function is monotonically decreasing w.r.t. the argument in question.Mixed(Vec<bool>),}
Activity
tinfoil-knight commentedon Mar 30, 2024
take
alamb commentedon May 21, 2024
#10504 introduces a new API for boundary propagation, so the API challenge described in this ticket is no longer relevant. Thus closing