Skip to content

Implement serialization for UDWF as window function in plan protobuf #4584 #6733

Closed

Description

@alamb

Is your feature request related to a problem or challenge?

Similarly to #4584

Follow on to #6703 to add serialization support for user defined window functions when serializing plans

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

Activity

  1. parkma99 commented on Jun 23, 2023

    @parkma99
    Contributor

    I would like to work this.Could you give me some tips for starting this issue?

  2. alamb commented on Jun 24, 2023

    @alamb
    ContributorAuthor

    The basic idea would be to fix this code: https://github.com/apache/arrow-datafusion/blob/80d1750fda0f8d1d09d7bbf5b05662b1f6618954/datafusion/proto/src/logical_plan/to_proto.rs#L593-L597

    I think you can generally follow the model of AggregateUDF

    So I would recommend this order:

    1. Write a round trip test first -- following the model of https://github.com/apache/arrow-datafusion/blob/80d1750fda0f8d1d09d7bbf5b05662b1f6618954/datafusion/proto/src/logical_plan/mod.rs#L2606-L2663
    2. Write the code
  3. parkma99 commented on Jun 25, 2023

    @parkma99
    Contributor

    I think you can generally follow the model of AggregateUDF

    @alamb Thanks, I will have a look late.😊

  4. Jefffrey commented on Oct 30, 2023

    @Jefffrey
    Contributor

    This issue looks good to close?

    cc @alamb

  5. alamb commented on Oct 30, 2023

    @alamb
    ContributorAuthor

    I agree -- thanks @Jefffrey (and @parkma99 !)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions