You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
CREATE TABLE defaults to NON nullable (should be nullable to follow postgres) #5575
DDL query. It defaults to non-nullable columns while creating a table, which is not the case in PostgreSQL 15.
NULL
The column is allowed to contain null values. This is the default.
This clause is only provided for compatibility with non-standard SQL databases. Its use is discouraged in new applications.
I tried to test CREATE TABLE table_without_values(field1 BIGINT NULL, field2 BIGINT NULL);, but found Error: NotImplemented("Only CREATE TABLE table_name AS SELECT ... statement is supported"). Is it reasonable?
I think we also support traditional create table. Moreover we already have methods to create database. @alamb I can create a separate ticket for traditional create table stmt
Integrating its support into the planner is straightforward. Simply changing the input of CreateMemoryTable (a logical plan) into optional, constructing a MemTable with vec![] and the correct schema is sufficient to enable this functionality.
Activity
alamb commentedon Mar 13, 2023
I think this is a good first issue as the desired behavior is well understood and the code location is identified
Weijun-H commentedon Mar 13, 2023
I tried to test
CREATE TABLE table_without_values(field1 BIGINT NULL, field2 BIGINT NULL);, but foundError: NotImplemented("OnlyCREATE TABLE table_name AS SELECT ...statement is supported"). Is it reasonable?comphead commentedon Mar 14, 2023
Currently on CTAS supported
I think we also support traditional create table. Moreover we already have methods to create database.
@alamb I can create a separate ticket for traditional create table stmt
metesynnada commentedon Mar 14, 2023
Integrating its support into the planner is straightforward. Simply changing the input of
CreateMemoryTable(a logical plan) into optional, constructing aMemTablewithvec![]and the correct schema is sufficient to enable this functionality.alamb commentedon Mar 15, 2023
Thank you @comphead -- that would be great!