You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
hash_join.rs's create_hashes function panics with float columns with nightly rustc #512
Interesting find @houqp . I think this needs to be fixed upstream, by e.g. casting to .
Any idea why it's using the fallback code of aHash at your end, what kind of cpu are you using?
This is probably related to Rust's unability to support hash for f32 and f64, as Eq is still not stabilized for them (and Hash and Eq must be consistent).
This is probably related to Rust's unability to support hash for f32 and f64, as Eq is still not stabilized for them (and Hash and Eq must be consistent).
@houqp found an issue tkaitchuck/aHash#93 in upstream (trying to hash an usize from a len() call). I think it could be solved easily there by casting it to u64. It's not totally clear to me what's the difference between nightly and stable.
I think i found what's causing the difference between stable and nightly: tkaitchuck/aHash#93 (comment). This turned on the specialize feature in ahash, which triggered the fallback code path.
I think ahash just need to implement usize write in this case like @Dandandan suggested. There is nothing much we could do on our end without incurring extra overhead like converting the byte array to u32 or u64 before hashing it.
Activity
Dandandan commentedon Jun 6, 2021
Interesting find @houqp . I think this needs to be fixed upstream, by e.g. casting to .
Any idea why it's using the fallback code of aHash at your end, what kind of cpu are you using?
jorgecarleitao commentedon Jun 6, 2021
This is probably related to Rust's unability to support hash for f32 and f64, as
Eqis still not stabilized for them (and Hash and Eq must be consistent).Dandandan commentedon Jun 6, 2021
@houqp found an issue tkaitchuck/aHash#93 in upstream (trying to hash an
usizefrom alen()call). I think it could be solved easily there by casting it tou64. It's not totally clear to me what's the difference between nightly and stable.houqp commentedon Jun 6, 2021
My CPU is Intel i7.
I think i found what's causing the difference between stable and nightly: tkaitchuck/aHash#93 (comment). This turned on the
specializefeature in ahash, which triggered the fallback code path.I think ahash just need to implement usize write in this case like @Dandandan suggested. There is nothing much we could do on our end without incurring extra overhead like converting the byte array to u32 or u64 before hashing it.
Small changes in docs (apache#512)