Skip to content

Consider making the DataFrame API less verbose by imitating Polars #4890

Open

Description

@oersted

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

I'd say that, for instance, .select(["name"]) is significantly easier to read and write than .select(vec![col("name")]).

Describe the solution you'd like

Polars deals with this by having the following more generic signature.

pub fn select<I, S>(&self, selection: I) -> Result<DataFrame, PolarsError>
where
    I: IntoIterator<Item = S>,
    S: AsRef<str>

IntoIterator makes a lot of sense, it allows for arrays for concise syntax and Vec or any other collection whenever the list is programmatically generated.

AsRef<str> is less clear, I'm not sure how they refer to complex expressions with a string reference. Perhaps Into<Expr> might be better with a default implementation for &str.

Yes I know that there's also a select_columns(&self, columns: &[&str]) method in the current API, but it is still less flexible, somewhat redundant, and there are other places where vec! and col() somewhat pollute the syntax still.

Activity

  1. alamb commented on Jan 15, 2023

    @alamb
    Contributor

    I agree this would be a great change ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions