Skip to content

Port other sql_integration test cases to sqllogictest #4870

Closed

Description

@ygf11

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

As @jackwener suggested in #4826 (comment), we can port the other part of sql_integration to sqllogictest now.
The sql_integration tests are in datafusion/core/tests/sql:

aggregates.rs
avro.rs
cast.rs
create_drop.rs
decimal.rs
errors.rs
explain_analyze.rs
...

The difference:

  • sql_integration will ensure the correctness of logical and physical plan.
  • sqllogictest will ensure the result is correct.

For the test cases, if we want to ensure the correctness of the plan, the test should be reserved in sql_integration.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Activity

  1. alamb commented on Jan 11, 2023

    @alamb
    Contributor

    Captured on #4460 where I have been collecting other related tickets

  2. aprimadi commented on Apr 23, 2023

    @aprimadi
    Contributor

    Isn't this a duplicate of 4495

  3. alamb commented on Apr 24, 2023

    @alamb
    Contributor

    Yes, I agree -- thank you @aprimadi - closing in favor of #4495

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions