You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Fix the test failures related to the logical optimizer. #4685
I reran cargo test --all with skip_failed_rule = false. It seems like some test failures has been fixed, but there are some newly generated. I've updated the task list.
Hi @alamb ,I've justed run cargo test with skip_failed_rules=false, and found 2 new failures. I'll update the task list to add them in.
failures:
---- sql::subqueries::support_limit_subquery stdout ----
Error: Context("decorrelate_where_in", Internal("Optimizer rule 'decorrelate_where_in' failed due to unexpected error: a projection is required at datafusion/optimizer/src/decorrelate_where_in.rs:152\ncaused by\nError during planning: Could not coerce into Projection! at datafusion/expr/src/logical_plan/plan.rs:1430"))
---- sql::window::window_frame_creation_type_checking stdout ----
thread 'sql::window::window_frame_creation_type_checking' panicked at 'Can not find expected in actual.
Expected:
Internal error: Operator - is not implemented for types UInt32(1) and Utf8("1 DAY").
Actual:
type_coercion
caused by
Internal error: Optimizer rule 'type_coercion' failed due to unexpected error: Execution error: Cannot cast Utf8("1 DAY") to UInt32. This was likely caused by a bug in DataFusion's code and we would welcome that you file an bug report in our issue tracker', datafusion/core/tests/sql/window.rs:47:9
failures:
sql::subqueries::support_limit_subquery
sql::window::window_frame_creation_type_checking
Activity
HaoYang670 commentedon Feb 14, 2023
I reran
cargo test --allwithskip_failed_rule = false. It seems like some test failures has been fixed, but there are some newly generated. I've updated the task list.HaoYang670 commentedon Feb 14, 2023
Full error messages for the tpcds failures:
askoa commentedon Feb 19, 2023
@jackwener You might want to add the issue #4887 to the list.
alamb commentedon Mar 23, 2023
I wonder how this project is going 🤔
HaoYang670 commentedon Mar 24, 2023
Hi @alamb ,I've justed run
cargo testwithskip_failed_rules=false, and found 2 new failures. I'll update the task list to add them in.alamb commentedon Mar 24, 2023
Thank you @HaoYang670
HaoYang670 commentedon Mar 30, 2023
Sorry, the
window_frame_creation_type_checkingdoesn't fail. I made a mistake in the testing environment.Have removed it from the task lists
wolffcm commentedon Apr 13, 2023
I found another issue in this vein: #5996
alamb commentedon Apr 13, 2023
Added to list
alamb commentedon Sep 28, 2024
We have enabled checking by default in #6265 so I think we can claim this ticket is complete