Skip to content

Error type in RecordBatchStream #4172

Closed

Description

@crepererum

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
RecordBatchStream is a DataFusion type. However it carries an ArrowError instead of DataFusionError. This leads to some wild error wrapping like this one:

https://github.com/apache/arrow-datafusion/blob/5883e43db6c16d3ac3616302606849abbfbc86eb/datafusion/core/src/physical_plan/aggregates/row_hash.rs#L181

This makes it hard to detect the actual underlying error, e.g. ResourceExhausted for "out of memory" (also see #3941 where this would be useful).

Describe the solution you'd like
Make RecordBatchStream a DataFusionError instead. I'm aware this is a quite major change.

Describe alternatives you've considered
-

Additional context
-

Activity

  1. crepererum commented on Jan 31, 2023

    @crepererum
    ContributorAuthor

    Closed by #5101.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions