Skip to content

Combine GroupByScalar and ScalarValue #376

Closed

Description

@alamb

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
There is non trivial overlap of similar, but not quite the same features in GroupByScalar and ScalarValue

As discussed on #364 (comment) we think this is an historical artifact and the code would be simpler / have fewer bugs if they were combined.

Describe the solution you'd like
COmbine the two classes (into ScalarValue)

Activity

  1. alamb commented on Jul 28, 2021

    @alamb
    ContributorAuthor

    One thing we have discovered while working on #768 is that the size of GroupByScalar is 16 bytes while ScalarValue is larger (currently 64 bytes but with #788 it could be 32 bytes).

    Another difference is that GroupByScalar has no way to represent "NULL" (and thus at the moment hash aggregates also do not support grouping by NULL)

  2. added a commit that references this issue on Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions