Skip to content

Prevent Cargo.lock for datafusion-cli being out-of-date #3744

Closed

Description

@isidentical

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Since the only Cargo.lock that is checked in is the datafusion-cli's one, we seem to be forgetting about updating it sometimes.

Describe the solution you'd like
Since we already have infrastructure (a lint job), I think it should be relatively simple to add a step that checks whether the Cargo.lock is up-to-date or not. It could then fail on PRs that change Cargo.toml (add new stuff to other crates), and let the PR authors know that they need to update the lock as well.

Describe alternatives you've considered
Leaving as is.

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions