Skip to content

support unsigned numeric data type in UnwrapCastInBinaryComparison rule #3702

Closed

Description

@liukun4515
    This plan doesn't look ideal to me -- since `col_int32` is int32 I think the exprs could be rewritten to 
CASE WHEN #test.col_int32 > Int32(0) THEN Int32(1) ELSE Int32(0) END

Could be done as a follow on PR for sure

Originally posted by @alamb in #3699 (comment)

Activity

  1. self-assigned this
    on Oct 4, 2022
  2. alamb commented on Oct 4, 2022

    @alamb
    Contributor

    To implement this, as @liukun4515 notes, the UnwrapCastInBinaryComparison code just needs to be extended to support unsigned types as well

  3. alamb commented on Nov 8, 2022

    @alamb
    Contributor

    I am working on this feature as we need it for IOx

  4. liukun4515 commented on Nov 9, 2022

    @liukun4515
    ContributorAuthor

    am working on this feature as we need

    look forward your pr

  5. alamb commented on Nov 12, 2022

    @alamb
    Contributor

    PR is now ready for review #4149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions