You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Consolidate optimizer passes in optimizer module for better testing #3524
However, while reviewing #3482 I noticed there were two separate lists of optimizer's that were instantiated -- one in an integration test and one in the core module.
This is bad as the lists can get out of sync meaning the tests may not provide as much coverage as we would like
Describe the solution you'd like
I would like the Optimizer pass lists to be in the datafusion-optimizer crate so it can be used by the integration test, and the interface to the overall optimizer to be more well defined
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Activity
andygrove commentedon Sep 20, 2022
Thanks @alamb. I had been intending to do some work in this direction as well. I think this sounds great.
andygrove commentedon Oct 3, 2022
@alamb I am working on this now because it became important to something that I am working on for this release
alamb commentedon Oct 3, 2022
Outstanding @andygrove -- the biggest issue I hit was extracting the passes from the state.
I am standing by to help review it and get it in quickly 👍