Skip to content

Improve consistency of expression names #3330

Closed

Description

@andygrove

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
We have many different ways to create names from expressions with duplicated and sometimes inconsistent code.

Logical Expression:

  • Display trait
  • Debug trait
  • Expr.name() method (wrapper for create_name function)
  • ExprIdentifierVisitor::desc_expr

Physical Expression:

  • Display trait
  • Debug trait
  • create_physical_name function

One example of confusion is that queries sometimes result in field names containing Divide and sometimes /. For example:

  • decimal_simple.c1 / CAST(Float64(0.00001) AS Decimal128(5, 5)) uses /
  • CAST(decimal_simple.c1 AS Decimal128(30, 19)) Divide CAST(decimal_simple.c5 AS Decimal128(30, 19)) uses Divide

Describe the solution you'd like
Make names more consistent and avoid duplicate code

Describe alternatives you've considered
None

Additional context
None

Activity

  1. self-assigned this
    on Sep 1, 2022
  2. andygrove commented on Sep 1, 2022

    @andygrove
    MemberAuthor

    Here are some observations after reviewing the logical plan code.

    • Display and Debug produce similar output. Display delegates to Debug for most cases.
    • create_name accepts a schema argument, which is never used. If we remove that, then the logic looks to be about the same as Display and Debug

    It seems to me that create_name should be used to determine the name of the expression as it would be represented in a schema, whereas Display would be used to create a representation of the expression to show in the logical plan. In many cases, these will be the same.

  3. removed their assignment
    on May 23, 2024
  4. andygrove commented on Nov 16, 2026

    @andygrove
    MemberAuthor

    Closing as fixed. The Divide vs / inconsistency is gone, and the duplicate naming paths (create_name, create_physical_name, ExprIdentifierVisitor::desc_expr) have been removed. Logical names now come from Expr::schema_name(), with Expr::human_display() for readable output. The broader discussion of simplifying default column names continues in #3990.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions