You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Introduce Expr variants for IS [NOT] TRUE / FALSE / UNKNOWN #3268
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
In #3252 we added support for SQL IS [NOT] TRUE/FALSE by mapping to the existing logical binary operator Is[Not]DistinctFrom. This resulted in a small PR compared to introducing new Expr variants such as IsNotTrue, but the downside is that we are now unable to implement type validation/coercion to ensure that the left expression is a boolean value.
Describe the solution you'd like
Introduce new Expr variants but still map to the physical plan for IsDistinctFrom.
Another option would be to add Operatror::IsTrue instead of a new Expr
Never mind, IS TRUE is a unary expression, not binary.
Hi @andygrove Do we need the other unary expression for IS_TRUE, IS_FALSE... ?
I go through preview pr for adding the sql syntax for above expr like that which convert the IS_TRUE to the binary expr
Activity
andygrove commentedon Aug 25, 2022
@sarahyurick fyi
andygrove commentedon Aug 25, 2022
Another option would be to addOperatror::IsTrueinstead of a newExprNever mind,
IS TRUEis a unary expression, not binary.liukun4515 commentedon Aug 27, 2022
Hi @andygrove Do we need the other unary expression for
IS_TRUE, IS_FALSE...?I go through preview pr for adding the sql syntax for above expr like that which convert the
IS_TRUEto the binary exprI am not sure if it is a good way.