You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
because the indents aren't trustworthy when subqueries are taken into account.
Also, I've had a hard time writing unit tests for optimizers because building them programmatically is verbose and error-prone.
Describe the solution you'd like
If we were to create a visitor method like display_json(), and an equivalent LogicalPlan::from_json() then both problems would be solved fairly elegantly. As a bonus, plans would be readable and manipulable by common off the the shelf tools and readable by the uninitiated.
Describe alternatives you've considered
Fixing the indentation on the formatter, writing different types of tests, crying into my beer.
As a potential implementation option, we could use something like https://docs.serde.rs/serde_json/ with our existing visitor pattern. I know some folks are reticent to add dependencies though, so I thought I would open this up for discussion. I'm after the ends, the means I'm flexible on.
Activity
avantgardnerio commentedon Jul 12, 2022
As a potential implementation option, we could use something like https://docs.serde.rs/serde_json/ with our existing visitor pattern. I know some folks are reticent to add dependencies though, so I thought I would open this up for discussion. I'm after the ends, the means I'm flexible on.
Add optional serde support to datafusion-proto (apache#2889)
Adds optional serde support to datafusion-proto (#2892)
avantgardnerio commentedon Jul 17, 2022
Thank you!!!