Skip to content

Resolve rustix and clipboard-win audit warnings #27451

Closed

Description

@Phoenix500526

Describe the bug

cargo audit reports four allowed warnings against the root Cargo.lock on main (verified at 73e0b03). Two can be resolved with compatible patch updates:

Dependency Current version Warning Proposed version
rustix 1.1.4 unsound, RUSTSEC-2026-0486 1.1.6
clipboard-win 5.4.1 yanked 5.4.3

The rustix advisory concerns extended-attribute functions marking unwritten bytes as initialized when given a zero-length buffer. This can cause undefined behavior through safe APIs; version 1.1.6 contains the fix.

clipboard-win 5.4.1 has been yanked. It is pulled in by datafusion-cli -> rustyline -> clipboard-win; 5.4.3 is a non-yanked replacement. This is a yanked-version warning, not a claim of a separate RustSec vulnerability in clipboard-win.

Plain cargo audit exits with code 0, so these warnings do not currently fail the Security audit CI job. They should nevertheless be addressed where fixed versions are available.

To Reproduce

Run from the repository root on the affected main revision:

cargo audit
# Or use the CI entry point:
bash ci/scripts/security_audit.sh

The output includes rustix 1.1.4 (unsound), clipboard-win 5.4.1 (yanked), and the two unmaintained dependencies listed below.

Expected behavior

Update only rustix and clipboard-win in Cargo.lock to resolve these two warnings:

cargo update -p rustix --precise 1.1.6
cargo update -p clipboard-win --precise 5.4.3

These versions fit the existing dependency constraints, so no Cargo.toml changes are needed. Keep the two unmaintained warnings visible while their upstream fixes work through releases and downstream dependency updates.

Additional context

The remaining warnings already have upstream PRs in progress:

Dependency Current dependency chain Upstream work
astral-tokio-tar 0.6.2 (RUSTSEC-2026-0440) datafusion-cli dev-dependency -> testcontainers-modules -> testcontainers -> astral-tokio-tar testcontainers/testcontainers-rs#1006, replacing it with tar
unsafe-libyaml 0.2.11 (RUSTSEC-2024-0449) datafusion-substrait -> substrait 0.63.0 build-dependency -> serde_yaml -> unsafe-libyaml substrait-io/substrait-packaging#105, replacing serde_yaml with yaml_serde in substrait-extensions; tracking issue: #104

Both upstream PRs are currently open. Newer Substrait versions move the YAML dependency into substrait-extensions, so DataFusion will need to adopt a release containing the packaging fix to benefit from it. These follow-ups are separate from the two lockfile updates proposed here.

Willingness to contribute

I plan to contribute a fix for this bug independently. A lockfile-only update for rustix and clipboard-win is already prepared.

Activity

  1. Phoenix500526 commented on Nov 15, 2026

    @Phoenix500526
    ContributorAuthor

    take

  2. added a commit that references this issue on Nov 17, 2026
    d58aaab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions