You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
function module in python binding is broken in 6.0 #1328
the function module in python binding is broken in 6.0
To Reproduce
In [1]: import datafusion
f
In [2]: from datafusion import functions
In [3]: dir(functions)
Out[3]:
['__builtins__',
'__cached__',
'__doc__',
'__file__',
'__getattr__',
'__loader__',
'__name__',
'__package__',
'__spec__',
'functions']
Expected behavior
expect the function module to be only one level below Datafusion.
Activity
houqp commentedon Nov 18, 2021
@jimexist this was intentional, see #1287 (comment).
houqp commentedon Nov 18, 2021
I don't have a strong opinion on this though, if you think there is a valid use-case for having the functions module, we can add it back.
houqp commentedon Nov 18, 2021
#1287 (comment) is the comment that made me change my mind on my original PR :)
jimexist commentedon Nov 18, 2021
so you are saying that we should use:
instead of
having two layers of
functionsis unintuitivejimexist commentedon Nov 18, 2021
ah I see now that I can do
houqp commentedon Nov 18, 2021
from datafusion import functions as fshould still work, it's just thatdatafusion.functionswon't work anymore.houqp commentedon Nov 18, 2021
oh, i see what confused you. yeah, it would be better if
dirworks withfunctionsmodule :(