You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem or challenge?
DataFusion doesn't support ordered-set aggregate functions yet.
Those functions are supported in Postgres, DuckDB, so I think we should support them in this repo as the core functions
All the aggregates listed in Table 9-51 ignore null values in their sorted input. For those that take a fraction parameter, the fraction value must be between 0 and 1; an error is thrown if not. However, a null fraction value simply produces a null result.
I think the first step is to solve #11732, fix the syntax of approx_percentile_cont and approx_percentile_cont _with_weight since there is no WITHIN GROUP currently. And the next step is to support order by and other functions.
@Garamda@jayzhan211 After the WITHIN GROUP is added, I would like to work on this for the ORDER BY impelmentations for approx_percentile_cont and approx_percentile_cont_with_weight
This task has taken longer than I initially expected, because recently I haven’t been able to fully focus on it. Nevertheless, I believe I can complete it successfully.
However, if this is a delay for the datafusion roadmap or has any negative effect on the ecosystem, I am open to passing this issue to a more experienced committer and shifting my focus to a other smaller issue.
If there’s still room for me to continue, I would like to see this issue through to completion.
I’m sharing this update to inform the current status, especially since some may be waiting for this issue’s completion.
Activity
Garamda commentedon Oct 9, 2024
Hi, I'm new here. I want to take the issue or participate in developing one of those functions. Would it be possible?
jayzhan211 commentedon Oct 9, 2024
Sure, just type
takethen you will be assignedGaramda commentedon Oct 9, 2024
Alright. Before I take the issue, let me be clear. What I understood is that the things to be implemented are those five functions below,
not including those two functions, is that correct?
Let me double check because there are 7 tasks in total in this issue checklist.
jayzhan211 commentedon Oct 9, 2024
I think the first step is to solve #11732, fix the syntax of
approx_percentile_contandapprox_percentile_cont _with_weightsince there is noWITHIN GROUPcurrently. And the next step is to support order by and other functions.[-]Ordered Set Aggregate Functions[/-][+]Epic: Ordered Set Aggregate Functions[/+]Garamda commentedon Oct 9, 2024
I see. So there are 3 sub tasks, I think.
approx_percentile_contandapprox_percentile_cont_with_weightto supportWITHIN GROUP(Standardize APPROX_PERCENTILE_CONT / PERCENTILE_CONT and similar aggregation functions #11732)ORDER BY sort_expressionWITHIN GROUP&ORDER BYwill be reused)If there is nothing that I missed, I can start from step 1.
So I think I can make a
takecomment on #11732 and get assigned, right?(or if you want to reorganize sub tasks and make new issues for each one since it was changed into
EPIC, I can wait.)jonathanc-n commentedon Oct 11, 2024
@Garamda @jayzhan211 After the WITHIN GROUP is added, I would like to work on this for the ORDER BY impelmentations for approx_percentile_cont and approx_percentile_cont_with_weight
Garamda commentedon Oct 31, 2024
This task has taken longer than I initially expected, because recently I haven’t been able to fully focus on it. Nevertheless, I believe I can complete it successfully.
However, if this is a delay for the datafusion roadmap or has any negative effect on the ecosystem, I am open to passing this issue to a more experienced committer and shifting my focus to a other smaller issue.
If there’s still room for me to continue, I would like to see this issue through to completion.
I’m sharing this update to inform the current status, especially since some may be waiting for this issue’s completion.
cc. @jayzhan211 @jonathanc-n
Garamda commentedon Feb 2, 2025
PR is ready to get review : #13511
cc. @jayzhan211
Jefffrey commentedon Oct 17, 2025
percentile_cont(fraction)added by #17988