Repository navigation
Update sqlite expectation for NOT IN list containing NULL (apache/datafusion#26548) - #24
Merged
Merged
Conversation
apache/datafusion#26548 teaches EliminateFilter that `x NOT IN (..., NULL)` can never be TRUE, so the filter becomes an empty relation. The divide by zero inside the IN list is therefore never evaluated and the query now returns no rows, which matches the original sqlite expected result. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
alamb
marked this pull request as ready for review
October 27, 2026 19:40
raghavyadav01
approved these changes
Oct 27, 2026
raghavyadav01
approved these changes
Oct 28, 2026
raghavyadav01
left a comment
raghavyadav01
left a comment
There was a problem hiding this comment.
Checked against #26548: with a NULL in the NOT IN list the predicate can never be true, so the filter folds to false and col0 / 0 is never evaluated. The empty result is also what SQLite itself returns for this query, so this removes a DataFusion-only override rather than adding one.
Jefffrey
approved these changes
Oct 28, 2026
Contributor
Author
|
Thakank you @Jefffrey |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the expected results for a query that now runs after the improvements in