Repository navigation
MsSql: Read one statement as the body of WHILE without BEGIN - #2992
Open
colinhacks wants to merge 3 commits into
Open
colinhacks wants to merge 3 commits into
colinhacks wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dialects: MsSql
WHILE @n < 10 SET @n = @n + 1; SELECT @n;parsed into a singleWhilewhose body held both theSETand theSELECT: withoutBEGIN,parse_whileread statements up to anENDor the end of input. Without the final;the same input failed withExpected: ;, found: EOF.T-SQL takes one statement or one
BEGIN ... ENDblock there. The body is now parsed as one statement unlessBEGINfollows, so the statements after it parse on their own, and aWHILEwith no body fails withExpected: an SQL statement, found: EOF.parse_whileis shared, so this applies to every dialect; none has a body withoutBEGINthat runs toEND.A body without
BEGINnow displays without a trailing;, so aWHILEinside aBEGIN ... ENDlist round-trips instead of printing;;. TheWHILEarm ofparse_conditional_statement_block, which no caller reached any more, is removed.Written with an AI coding assistant.