Skip to content

Fix ClickHouse numeric roundtrip test without bigdecimal - #2918

Merged
LucaCappelletti94 merged 1 commit into
apache:mainfrom
lovasoa:fix-clickhouse-numeric-roundtrip
Nov 11, 2026
Merged

LucaCappelletti94 merged 1 commit into
apache:mainfrom
lovasoa:fix-clickhouse-numeric-roundtrip

Conversation

@lovasoa

@lovasoa lovasoa commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Fix the ClickHouse tuple element access test when the bigdecimal feature is disabled. Without that feature, numeric literals retain their original spelling, so .5 and 1e3 roundtrip unchanged; with it, they normalize to 0.5 and 1000. The previous test assumed normalization in both configurations, causing default cargo test to fail.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.22%. Comparing base (365cca6) to head (d7abf67).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2918   +/-   ##
=======================================
  Coverage   83.22%   83.22%           
=======================================
  Files          42       42           
  Lines       36490    36490           
  Branches    36490    36490           
=======================================
  Hits        30367    30367           
  Misses       2628     2628           
  Partials     3495     3495           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaCappelletti94

Copy link
Copy Markdown
Contributor

LGTM, thanks @lovasoa

cc @alamb

@LucaCappelletti94
LucaCappelletti94 added this pull request to the merge queue Nov 11, 2026
Merged via the queue into apache:main with commit de2e10b Nov 11, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants