Skip to content

feat/adding scalar-variable expression - #1260

Closed
devanbenz wants to merge 5 commits into
apache:mainfrom
devanbenz:feat/add-scalar-var-expr
Closed

devanbenz wants to merge 5 commits into
apache:mainfrom
devanbenz:feat/add-scalar-var-expr

Conversation

@devanbenz

Copy link
Copy Markdown
Contributor

@coveralls

coveralls commented May 5, 2024 •

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 8973785216

Details

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 89.196%

Totals Coverage Status
Change from base Build 8973304753: 0.003%
Covered Lines: 24314
Relevant Lines: 27259

💛 - Coveralls

Comment thread src/ast/mod.rs
OuterJoin(Box<Expr>),
/// A reference to the prior level in a CONNECT BY clause.
Prior(Box<Expr>),
/// Scalar variable creation e.g. `[@]foo INT`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add a link to some documentation that uses this expression? I think that would be helpful in this case - e.g I'm unfamiliar with the syntax and unable to tell how it's used as a result

Comment thread src/ast/mod.rs
/// A reference to the prior level in a CONNECT BY clause.
Prior(Box<Expr>),
/// Scalar variable creation e.g. `[@]foo INT`
ScalarVariable {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, it looks like we're missing implementation in the PR for how the parser actually parses/constructs the ScalarVariable expression or is that intended?

@devanbenz

Copy link
Copy Markdown
Contributor Author

@iffyio it is likely that this PR will not be needed, there is another route I am taking with the Scalar Variable in datafusion 👍 will leave it up just in case though.

@alamb
alamb marked this pull request as draft May 13, 2024 19:32
@alamb

alamb commented May 13, 2024

Copy link
Copy Markdown
Contributor

marking as draft as we sort out what to do here

@github-actions

Copy link
Copy Markdown

Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions Bot added the Stale label Feb 14, 2025
@devanbenz devanbenz closed this Feb 14, 2025
@devanbenz
devanbenz deleted the feat/add-scalar-var-expr branch February 14, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants