Skip to content

Update the java doc for the method disconnectPhysicalDiskByPath #9210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yadvr merged 1 commit into from
Jun 11, 2024
Merged

Update the java doc for the method disconnectPhysicalDiskByPath #9210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/StorageAdaptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,17 @@ public KVMPhysicalDisk createPhysicalDisk(String name, KVMStoragePool pool,

public boolean disconnectPhysicalDisk(Map<String, String> volumeToDisconnect);

// given local path to file/device (per Libvirt XML), 1) check that device is
// handled by your adaptor, return false if not. 2) clean up device, return true
/**
* Given local path to file/device (per Libvirt XML),
* 1) Make sure to check that device is handled by your adaptor, return false if not.
* 2) clean up device, return true
* 3) if clean up fails, then return false
*
* If the method wrongly returns true, then there are chances that disconnect will not reach the right storage adapter
*
* @param localPath path for the file/device from the disk definition per Libvirt XML.
* @return true if the operation is successful; false if the operation fails or the adapter fails to handle the path.
*/
public boolean disconnectPhysicalDiskByPath(String localPath);

public boolean deletePhysicalDisk(String uuid, KVMStoragePool pool, Storage.ImageFormat format);
Expand Down