server,test: fix resourceid for VOLUME.DESTROY in restore VM by shwstppr · Pull Request #9032 · apache/cloudstack

shwstppr · 2024-05-02T21:29:22Z

Description

Destroys old ROOT volume for the VM to be restored in its own context to allow event to be published with resourceid. Fixes exception in test_event_resources.py
Fixes failures seen in:
#8601 (comment)
#8601 (comment)
#8601 (comment)

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Destroy old ROOT volume for the VM to be restored in its own context to allow event to be published with resourceid. Fixes exception in test_event_resources.py Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2024-05-02T21:31:27Z

@blueorangutan package

blueorangutan · 2024-05-02T21:32:03Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov-commenter · 2024-05-02T22:14:15Z

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 14.96%. Comparing base (ea9a0f4) to head (07acb7c).
Report is 1 commits behind head on 4.19.

Files	Patch %	Lines
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19    #9032      +/-   ##
============================================
- Coverage     14.96%   14.96%   -0.01%     
+ Complexity    10995    10989       -6     
============================================
  Files          5373     5373              
  Lines        469024   469024              
  Branches      58818    61101    +2283     
============================================
- Hits          70197    70177      -20     
- Misses       391056   391078      +22     
+ Partials       7771     7769       -2

Flag	Coverage Δ
uitests	`4.31% <ø> (ø)`
unittests	`15.66% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

blueorangutan · 2024-05-02T22:55:45Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9520

weizhouapache · 2024-05-03T06:46:03Z

@blueorangutan test rocky8 kvm-rocky8

blueorangutan · 2024-05-03T06:48:03Z

@weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests

blueorangutan · 2024-05-03T07:24:34Z

[SF] Trillian Build Failed (tid-10150)

weizhouapache · 2024-05-03T08:44:24Z

@blueorangutan test rocky8 kvm-rocky8

blueorangutan · 2024-05-03T08:46:03Z

@weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests

blueorangutan · 2024-05-03T22:24:51Z

[SF] Trillian test result (tid-10151)
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 46971 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9032-t10151-kvm-rocky8.zip
Smoke tests completed. 129 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_restore_vm	`Error`	0.21	test_restore_vm.py
test_02_restore_vm_allocated_root	`Error`	0.17	test_restore_vm.py
ContextSuite context=TestRestoreVM>:teardown	`Error`	1.27	test_restore_vm.py
test_02_trigger_shutdown	`Failure`	341.57	test_safe_shutdown.py

shwstppr · 2024-05-06T08:07:42Z

Failed tests are unrelated, #8601 (comment)

vishesh92

clgtm

weizhouapache

code lgtm

sureshanaparti

clgtm

sureshanaparti · 2024-05-08T12:14:25Z

@blueorangutan package

blueorangutan · 2024-05-08T12:16:03Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-05-08T13:26:55Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9577

vishesh92 · 2024-05-08T13:27:58Z

@blueorangutan test

blueorangutan · 2024-05-08T13:30:03Z

@vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2024-05-09T02:05:05Z

[SF] Trillian test result (tid-10191)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43205 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9032-t10191-kvm-centos7.zip
Smoke tests completed. 124 look OK, 7 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_DeployVmAntiAffinityGroup_in_project	`Error`	85.31	test_affinity_groups_projects.py
test_DeployVmAntiAffinityGroup	`Error`	37.76	test_affinity_groups.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	33.13	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	0.08	test_kubernetes_clusters.py
test_01_non_strict_host_anti_affinity	`Failure`	119.79	test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity	`Error`	81.66	test_nonstrict_affinity_group.py
test_02_trigger_shutdown	`Failure`	346.79	test_safe_shutdown.py
test_02_list_cpvm_vm	`Failure`	0.04	test_ssvm.py
test_04_cpvm_internals	`Failure`	0.04	test_ssvm.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	304.95	test_hostha_kvm.py

shwstppr · 2024-05-09T06:33:38Z

@blueorangutan package

blueorangutan · 2024-05-09T06:34:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-05-09T07:47:08Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9581

vishesh92 · 2024-05-09T09:09:45Z

@blueorangutan test

blueorangutan · 2024-05-09T09:12:05Z

@vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2024-05-10T01:20:45Z

[SF] Trillian test result (tid-10198)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 56385 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9032-t10198-kvm-centos7.zip
Smoke tests completed. 130 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_trigger_shutdown	`Failure`	341.65	test_safe_shutdown.py

) Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

) (apache#454) Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

server,test: fix resourceid for VOLUME.DETROY in restore VM

3986a49

Destroy old ROOT volume for the VM to be restored in its own context to allow event to be published with resourceid. Fixes exception in test_event_resources.py Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

boring-cyborg Bot added component:integration-test Python Warning... Python code Ahead! labels May 2, 2024

shwstppr requested review from DaanHoogland, vishesh92 and weizhouapache May 6, 2024 08:09

vishesh92 approved these changes May 6, 2024

View reviewed changes

DaanHoogland approved these changes May 6, 2024

View reviewed changes

weizhouapache approved these changes May 6, 2024

View reviewed changes

sureshanaparti approved these changes May 8, 2024

View reviewed changes

sureshanaparti changed the title ~~server,test: fix resourceid for VOLUME.DETROY in restore VM~~ server,test: fix resourceid for VOLUME.DESTROY in restore VM May 8, 2024

sureshanaparti added this to the 4.19.1.0 milestone May 8, 2024

Merge branch '4.19' into fix-eventresourcestest-error

07acb7c

shwstppr marked this pull request as ready for review May 22, 2024 06:08

shwstppr closed this May 22, 2024

shwstppr reopened this May 22, 2024

DaanHoogland merged commit 33659fd into apache:4.19 May 22, 2024

DaanHoogland deleted the fix-eventresourcestest-error branch May 22, 2024 09:02

weizhouapache mentioned this pull request May 24, 2024

test_events_resource fails in unrelated changes #9122

Closed

my-code-AL pushed a commit to my-code-AL/cloudstack that referenced this pull request May 31, 2024

server,test: fix resourceid for VOLUME.DETROY in restore VM (apache#9032

0ad4c79

) Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 17, 2024

server,test: fix resourceid for VOLUME.DETROY in restore VM (apache#9032

fddbc4c

) Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr added a commit to shapeblue/cloudstack that referenced this pull request Sep 5, 2024

server,test: fix resourceid for VOLUME.DETROY in restore VM (apache#9032

08246e0

) (apache#454) Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

Conversation

shwstppr commented May 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

shwstppr commented May 2, 2024

Uh oh!

blueorangutan commented May 2, 2024

Uh oh!

codecov-commenter commented May 2, 2024 • edited by codecov Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented May 2, 2024

Uh oh!

weizhouapache commented May 3, 2024

Uh oh!

blueorangutan commented May 3, 2024

Uh oh!

blueorangutan commented May 3, 2024

Uh oh!

weizhouapache commented May 3, 2024

Uh oh!

blueorangutan commented May 3, 2024

Uh oh!

blueorangutan commented May 3, 2024

Uh oh!

shwstppr commented May 6, 2024

Uh oh!

vishesh92 left a comment

Choose a reason for hiding this comment

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented May 8, 2024

Uh oh!

blueorangutan commented May 8, 2024

Uh oh!

blueorangutan commented May 8, 2024

Uh oh!

vishesh92 commented May 8, 2024

Uh oh!

blueorangutan commented May 8, 2024

Uh oh!

blueorangutan commented May 9, 2024

Uh oh!

shwstppr commented May 9, 2024

Uh oh!

blueorangutan commented May 9, 2024

Uh oh!

blueorangutan commented May 9, 2024

Uh oh!

vishesh92 commented May 9, 2024

Uh oh!

blueorangutan commented May 9, 2024

Uh oh!

blueorangutan commented May 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

shwstppr commented May 2, 2024 •

edited

Loading

codecov-commenter commented May 2, 2024 •

edited by codecov Bot

Loading