Skip to content

Fixup listing of serivce offering & storagepools with tags - #8937

Merged
DaanHoogland merged 1 commit into
apache:4.19from
shapeblue:fixup-listing-issues
Apr 25, 2024
Merged

DaanHoogland merged 1 commit into
apache:4.19from
shapeblue:fixup-listing-issues

Conversation

@vishesh92

@vishesh92 vishesh92 commented Apr 18, 2024 •

Copy link
Copy Markdown
Member

Description

This PR fixes listing of service offering & stroagepools with tags.

  1. Add 2 tags to a storage pool. The list operation fails.
  2. List services offerings for a VM with service offering tags.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@vishesh92

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@vishesh92

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@sureshanaparti sureshanaparti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@sureshanaparti sureshanaparti added this to the 4.19.1.0 milestone Apr 22, 2024
@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9351

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9352

@vishesh92
vishesh92 force-pushed the fixup-listing-issues branch from dcfed7c to b43915a Compare April 24, 2024 06:35
@vishesh92

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9385

@borisstoyanov

Copy link
Copy Markdown
Contributor

@blueorangutan test keepEnv

@blueorangutan

Copy link
Copy Markdown

@borisstoyanov a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@yadvr
yadvr marked this pull request as ready for review April 24, 2024 12:25
@yadvr
yadvr requested a review from borisstoyanov April 24, 2024 12:27
@blueorangutan

Copy link
Copy Markdown

[SF] Trillian test result (tid-9983)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46632 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8937-t9983-kvm-centos7.zip
Smoke tests completed. 129 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_events_resource Error 422.19 test_events_resource.py

@borisstoyanov borisstoyanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, manually tested the api, it considers tags when listing the suitable offerings

@DaanHoogland
DaanHoogland merged commit e409c6d into apache:4.19 Apr 25, 2024
@DaanHoogland
DaanHoogland deleted the fixup-listing-issues branch April 25, 2024 10:58
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants