Skip to content

packaging: move juniper-contrail network plugin to noredist build - #8932

Merged
DaanHoogland merged 1 commit into
apache:4.18from
weizhouapache:4.18-contrail-noredist
Apr 24, 2024
Merged

DaanHoogland merged 1 commit into
apache:4.18from
weizhouapache:4.18-contrail-noredist

Conversation

@weizhouapache

Copy link
Copy Markdown
Member

Description

This PR moves juniper-contrail to noredist and removes the repository for it.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9291

@weizhouapache weizhouapache added this to the 4.18.3 milestone Apr 17, 2024
@weizhouapache
weizhouapache marked this pull request as ready for review April 17, 2024 13:21
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.17%. Comparing base (f731fe8) to head (8a80f5c).
Report is 20 commits behind head on 4.18.

Additional details and impacted files
@@            Coverage Diff             @@
##               4.18    #8932    +/-   ##
==========================================
  Coverage     13.16%   13.17%            
- Complexity     9203     9216    +13     
==========================================
  Files          2724     2725     +1     
  Lines        258130   258240   +110     
  Branches      40232    40249    +17     
==========================================
+ Hits          33989    34016    +27     
- Misses       219833   219912    +79     
- Partials       4308     4312     +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weizhouapache
weizhouapache force-pushed the 4.18-contrail-noredist branch from 8a80f5c to 206929f Compare April 17, 2024 14:42

@sureshanaparti sureshanaparti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@weizhouapache

Copy link
Copy Markdown
Member Author

@blueorangutan test rocky8 kvm-rocky8

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian test result (tid-9897)
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 44632 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8932-t9897-kvm-rocky8.zip
Smoke tests completed. 109 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_migrate_VM_and_root_volume Error 86.57 test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks Error 53.03 test_vm_life_cycle.py
test_08_migrate_vm Error 0.06 test_vm_life_cycle.py

@weizhouapache

Copy link
Copy Markdown
Member Author

@blueorangutan test rocky8 kvm-rocky8

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian test result (tid-9914)
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 45681 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8932-t9914-kvm-rocky8.zip
Smoke tests completed. 109 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_migrate_VM_and_root_volume Error 92.82 test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks Error 59.23 test_vm_life_cycle.py
test_08_migrate_vm Error 0.07 test_vm_life_cycle.py

@weizhouapache

Copy link
Copy Markdown
Member Author

are we ok to merge this ? I can rebase with 4.19 or 4.20

@DaanHoogland @rohityadavcloud @sureshanaparti

@DaanHoogland
DaanHoogland merged commit 5f6acca into apache:4.18 Apr 24, 2024
@DaanHoogland
DaanHoogland deleted the 4.18-contrail-noredist branch April 24, 2024 08:29
DaanHoogland added a commit that referenced this pull request Apr 24, 2024
* 4.18:
  packaging: move contrail network plugin to noredist (#8932)
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request May 3, 2024
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request May 3, 2024
* 4.18:
  packaging: move contrail network plugin to noredist (apache#8932)
@yadvr yadvr modified the milestones: 4.18.3, 4.19.1.0 Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

6 participants