Skip to content

sanatise log in case multiple passwords have been passed - #8891

Merged
DaanHoogland merged 1 commit into
apache:mainfrom
shapeblue:ghi8852-logSanitation
Apr 29, 2024
Merged

DaanHoogland merged 1 commit into
apache:mainfrom
shapeblue:ghi8852-logSanitation

Conversation

@DaanHoogland

Copy link
Copy Markdown
Contributor

Description

This PR...

Fixes: #8852

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@DaanHoogland DaanHoogland changed the title sanatise log in case multiple passwordsa have been passed sanatise log in case multiple passwords have been passed Apr 12, 2024

@sureshanaparti sureshanaparti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hsato03 hsato03 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@DaanHoogland

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@apache apache deleted a comment from sureshanaparti Apr 23, 2024
@apache apache deleted a comment from blueorangutan Apr 23, 2024
@apache apache deleted a comment from blueorangutan Apr 23, 2024
@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 9378

@sureshanaparti

Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian test result (tid-9974)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45404 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8891-t9974-kvm-centos7.zip
Smoke tests completed. 129 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_events_resource Error 415.91 test_events_resource.py

@DaanHoogland

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian test result (tid-10016)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 52746 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8891-t10016-kvm-centos7.zip
Smoke tests completed. 126 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_events_resource Error 425.63 test_events_resource.py
test_08_arping_in_ssvm Failure 5.22 test_diagnostics.py
test_02_trigger_shutdown Failure 357.44 test_safe_shutdown.py
test_11_destroy_ssvm Error 3.22 test_ssvm.py

@DaanHoogland
DaanHoogland force-pushed the ghi8852-logSanitation branch from 2498755 to 814cbd0 Compare April 26, 2024 07:17
@DaanHoogland

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov-commenter

codecov-commenter commented Apr 26, 2024 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 15.28%. Comparing base (b93a86c) to head (814cbd0).

Files Patch % Lines
server/src/main/java/com/cloud/api/ApiServer.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8891      +/-   ##
============================================
- Coverage     15.28%   15.28%   -0.01%     
  Complexity    11524    11524              
============================================
  Files          5425     5425              
  Lines        474016   474016              
  Branches      61139    58087    -3052     
============================================
- Hits          72444    72442       -2     
- Misses       393515   393519       +4     
+ Partials       8057     8055       -2     
Flag Coverage Δ
uitests 4.27% <ø> (ø)
unittests 16.01% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9436

@DaanHoogland

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian test result (tid-10047)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 47863 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8891-t10047-kvm-centos7.zip
Smoke tests completed. 129 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_events_resource Error 424.40 test_events_resource.py

@DaanHoogland
DaanHoogland merged commit 54926c3 into apache:main Apr 29, 2024
@DaanHoogland
DaanHoogland deleted the ghi8852-logSanitation branch April 29, 2024 07:37
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request May 3, 2024
@DaanHoogland DaanHoogland added this to the 4.20.0.0 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sesitive information of request.getRequestLine() may leak

6 participants