Allow kvm storage plugin to customize diskdef, add geometry by sureshanaparti · Pull Request #8839 · apache/cloudstack

sureshanaparti · 2024-03-27T07:48:46Z

Description

This PR allows KVM storage plugin an opportunity to customize the libvirt disk XML.

The new interface method customizeLibvirtDiskDef facilitates plugin-specific config without having to add new methods for each specific thing that may need customizing. Existing plugins should be unaffected because of default implementation in interface.

Additionally, this adds the capability to define geometry in the libvirt disk definition.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

sureshanaparti · 2024-03-27T07:49:13Z

@blueorangutan package

blueorangutan · 2024-03-27T07:50:03Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2024-03-27T07:57:41Z

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 31.11%. Comparing base (e44c17e) to head (ba012cf).

Files	Patch %	Lines
...ervisor/kvm/resource/LibvirtComputingResource.java	0.00%	2 Missing ⚠️
...m/cloud/hypervisor/kvm/storage/KVMStoragePool.java	0.00%	1 Missing ⚠️
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #8839      +/-   ##
============================================
+ Coverage     30.93%   31.11%   +0.17%     
- Complexity    33753    33989     +236     
============================================
  Files          5404     5404              
  Lines        380309   380323      +14     
  Branches      55507    55508       +1     
============================================
+ Hits         117658   118328     +670     
+ Misses       247041   246323     -718     
- Partials      15610    15672      +62

Flag	Coverage Δ
simulator-marvin-tests	`24.86% <0.00%> (+0.31%)`	⬆️
uitests	`4.34% <ø> (ø)`
unit-tests	`16.88% <71.42%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

blueorangutan · 2024-03-27T08:59:52Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9051

sureshanaparti · 2024-03-27T09:21:29Z

@blueorangutan test

blueorangutan · 2024-03-27T09:22:04Z

@sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2024-03-28T02:17:52Z

[SF] Trillian test result (tid-9591)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 59451 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8839-t9591-kvm-centos7.zip
Smoke tests completed. 126 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_attach_and_distribute_multiple_volumes	`Failure`	37.68	test_attach_multiple_volumes.py
test_01_verify_ipv6_vpc	`Error`	680.82	test_vpc_ipv6.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Failure`	631.02	test_vpc_redundant.py
test_02_redundant_VPC_default_routes	`Failure`	1510.79	test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Failure`	481.93	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Failure`	554.30	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	554.32	test_vpc_redundant.py

DaanHoogland

clgtm

DaanHoogland · 2024-03-29T14:56:13Z

@blueorangutan test alma9 kvm-alma9

blueorangutan · 2024-03-29T14:58:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

blueorangutan · 2024-03-30T05:01:30Z

[SF] Trillian test result (tid-9626)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 48870 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8839-t9626-kvm-alma9.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

borisstoyanov · 2024-04-01T07:28:05Z

@blueorangutan test matrix

blueorangutan · 2024-04-01T07:30:06Z

@borisstoyanov a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2024-04-01T22:11:58Z

[SF] Trillian test result (tid-9641)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 50338 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8839-t9641-kvm-centos7.zip
Smoke tests completed. 127 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_enableHumanReadableLogs	`Error`	0.20	test_human_readable_logs.py
test_hostha_enable_ha_when_host_disabled	`Error`	3.95	test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	308.21	test_hostha_kvm.py

blueorangutan · 2024-04-01T22:50:47Z

[SF] Trillian test result (tid-9640)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 52787 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8839-t9640-xenserver-71.zip
Smoke tests completed. 128 look OK, 0 have errors, 1 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
all_test_human_readable_logs	`Skipped`	---	test_human_readable_logs.py

blueorangutan · 2024-04-02T01:20:52Z

[SF] Trillian test result (tid-9642)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 61671 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8839-t9642-vmware-67u3.zip
Smoke tests completed. 126 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80	`Error`	354.61	test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80	`Error`	354.63	test_internal_lb.py
test_01_disableHumanReadableLogs	`Error`	0.38	test_human_readable_logs.py
test_01_deploy_vm_on_specific_host	`Error`	0.22	test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster	`Error`	0.23	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	`Error`	0.25	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	0.36	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	`Error`	0.24	test_vm_deployment_planner.py

codecov-commenter · 2024-04-04T14:39:19Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.32%. Comparing base (e44c17e) to head (3589e4a).
Report is 27 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #8839       +/-   ##
============================================
- Coverage     30.93%   4.32%   -26.62%     
============================================
  Files          5404     361     -5043     
  Lines        380309   29121   -351188     
  Branches      55507    5108    -50399     
============================================
- Hits         117658    1260   -116398     
+ Misses       247041   27719   -219322     
+ Partials      15610     142    -15468

Flag	Coverage Δ
simulator-marvin-tests	`?`
uitests	`4.32% <ø> (-0.02%)`	⬇️
unit-tests	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

borisstoyanov · 2024-04-17T06:35:17Z

@blueorangutan package

blueorangutan · 2024-04-17T06:36:03Z

@borisstoyanov a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-04-17T07:58:15Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9285

borisstoyanov · 2024-04-17T10:34:43Z

@blueorangutan test alma9 kvm-alma9 keepEnv

blueorangutan · 2024-04-17T10:36:03Z

@borisstoyanov a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

blueorangutan · 2024-04-18T01:38:32Z

[SF] Trillian test result (tid-9878)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 52051 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8839-t9878-kvm-alma9.zip
Smoke tests completed. 127 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	`Error`	328.67	test_events_resource.py
test_01_events_resource	`Error`	328.68	test_events_resource.py
test_04_deploy_vm_for_other_user_and_test_vm_operations	`Failure`	89.78	test_network_permissions.py
ContextSuite context=TestNetworkPermissions>:teardown	`Error`	1.53	test_network_permissions.py

borisstoyanov

LGTM, based on code review and smoketests

) * Allow kvm storage plugin to customize diskdef, add geometry * formatting update --------- Co-authored-by: Marcus Sorensen <mls@apple.com>

Allow kvm storage plugin to customize diskdef, add geometry

ba012cf

boring-cyborg Bot added the component:kvm label Mar 27, 2024

sureshanaparti marked this pull request as ready for review March 28, 2024 08:06

sureshanaparti requested a review from weizhouapache March 28, 2024 08:07

DaanHoogland approved these changes Mar 29, 2024

View reviewed changes

Comment thread plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java Outdated

formatting update

3589e4a

yadvr added this to the 4.20.0.0 milestone Apr 9, 2024

yadvr requested a review from borisstoyanov April 9, 2024 06:17

DaanHoogland mentioned this pull request Apr 18, 2024

Unstable 4.19 and main branch smoketests #8931

Closed

borisstoyanov approved these changes Apr 18, 2024

View reviewed changes

yadvr merged commit dfd5158 into apache:main Apr 18, 2024

yadvr deleted the kvm-pool-custom-diskdef branch April 18, 2024 12:51

Conversation

sureshanaparti commented Mar 27, 2024

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

sureshanaparti commented Mar 27, 2024

Uh oh!

blueorangutan commented Mar 27, 2024

Uh oh!

codecov Bot commented Mar 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Mar 27, 2024

Uh oh!

sureshanaparti commented Mar 27, 2024

Uh oh!

blueorangutan commented Mar 27, 2024

Uh oh!

blueorangutan commented Mar 28, 2024

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DaanHoogland commented Mar 29, 2024

Uh oh!

blueorangutan commented Mar 29, 2024

Uh oh!

blueorangutan commented Mar 30, 2024

Uh oh!

borisstoyanov commented Apr 1, 2024

Uh oh!

blueorangutan commented Apr 1, 2024

Uh oh!

blueorangutan commented Apr 1, 2024

Uh oh!

blueorangutan commented Apr 1, 2024

Uh oh!

blueorangutan commented Apr 2, 2024

Uh oh!

codecov-commenter commented Apr 4, 2024

Codecov Report

Uh oh!

borisstoyanov commented Apr 17, 2024

Uh oh!

blueorangutan commented Apr 17, 2024

Uh oh!

blueorangutan commented Apr 17, 2024

Uh oh!

borisstoyanov commented Apr 17, 2024

Uh oh!

blueorangutan commented Apr 17, 2024

Uh oh!

blueorangutan commented Apr 18, 2024

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov Bot commented Mar 27, 2024 •

edited

Loading