VR: fix dnmasq misconfiguration if there are multiple IP ranges in a shared network

[weizhouapache]

Description

This PR fixes #8158

This PR also allows specifying IP in non-default IP range of shared networks when deploy a VM.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.17%. Comparing base (10f72a1) to head (3dd5d4c).
Report is 1 commits behind head on 4.18.

Additional details and impacted files

@@            Coverage Diff            @@
##               4.18    #8741   +/-   ##
=========================================
  Coverage     13.17%   13.17%           
  Complexity     9204     9204           
=========================================
  Files          2724     2724           
  Lines        258137   258137           
  Branches      40235    40235           
=========================================
  Hits          33998    33998           
  Misses       219830   219830           
  Partials       4309     4309           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sureshanaparti]

@blueorangutan package

[sureshanaparti]

clgtm

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8863

[yadvr]

@blueorangutan test

[blueorangutan]

@rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-9428)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42273 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8741-t9428-kvm-centos7.zip
Smoke tests completed. 109 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_migrate_vm	Error	43.84	test_vm_life_cycle.py

[weizhouapache]

@blueorangutan package

[weizhouapache]

@ccycv
can you test it ?

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9393

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[ccycv]

@ccycv can you test it ?

Just tested in 2 different environments, CloudStack 4.18.1 and 4.19, looks fine. I only think the MTU should be at the end of the config file; right now, it is after the first guest network.

This is how looks a cloud.conf with 5 guest ranges:

listen-address=127.0.0.1,149.xxx.xxx.53,91.xxx.xxx.137,51.xxx.xxx.66,217.xxx.xxx.51,217.xxx.xxx.182
dhcp-range=set:interface-eth0-0,149.xxx.xxx.53,static
dhcp-option=tag:interface-eth0-0,15,cs1cloud.internal
dhcp-option=tag:interface-eth0-0,6,149.xxx.xxx.53,8.8.4.4,8.8.8.8
dhcp-option=tag:interface-eth0-0,3,149.xxx.xxx.62
dhcp-option=eth0,26,1500
dhcp-option=tag:interface-eth0-0,1,255.255.255.240
dhcp-range=set:interface-eth0-1,91.xxx.xxx.137,static
dhcp-option=tag:interface-eth0-1,15,cs1cloud.internal
dhcp-option=tag:interface-eth0-1,6,91.xxx.xxx.137,8.8.4.4,8.8.8.8
dhcp-option=tag:interface-eth0-1,3,91.xxx.xxx.142
dhcp-option=tag:interface-eth0-1,1,255.255.255.240
dhcp-range=set:interface-eth0-2,51.xxx.xxx.66,static
dhcp-option=tag:interface-eth0-2,15,cs1cloud.internal
dhcp-option=tag:interface-eth0-2,6,51.xxx.xxx.66,8.8.4.4,8.8.8.8
dhcp-option=tag:interface-eth0-2,3,51.xxx.xxx.126
dhcp-option=tag:interface-eth0-2,1,255.255.255.192
dhcp-range=set:interface-eth0-3,217.xxx.xxx.51,static
dhcp-option=tag:interface-eth0-3,15,cs1cloud.internal
dhcp-option=tag:interface-eth0-3,6,217.xxx.xxx.51,8.8.4.4,8.8.8.8
dhcp-option=tag:interface-eth0-3,3,217.xxx.xxx.62
dhcp-option=tag:interface-eth0-3,1,255.255.255.224
dhcp-range=set:interface-eth0-4,217.xxx.xxx.182,static
dhcp-option=tag:interface-eth0-4,15,cs1cloud.internal
dhcp-option=tag:interface-eth0-4,6,217.xxx.xxx.182,8.8.4.4,8.8.8.8
dhcp-option=tag:interface-eth0-4,3,217.xxx.xxx.190
dhcp-option=tag:interface-eth0-4,1,255.255.255.224

[weizhouapache]

dhcp-option=eth0,26,1500

@ccycv
You tested with the changes in this PR, right ? just to confirm

[ccycv]

dhcp-option=eth0,26,1500

@ccycv You tested with the changes in this PR, right ? just to confirm

Yes, with this PR

[weizhouapache]

dhcp-option=eth0,26,1500

@ccycv You tested with the changes in this PR, right ? just to confirm

Yes, with this PR

great, thanks @ccycv
let's merge this pr

we can address the mtu issue in a separated pr if it causes mtu misconfiguration inside the vms

[ccycv]

dhcp-option=eth0,26,1500

@ccycv You tested with the changes in this PR, right ? just to confirm

Yes, with this PR

great, thanks @ccycv let's merge this pr

we can address the mtu issue in a separated pr if it causes mtu misconfiguration inside the vms

Just detected an issue, i see this in health check :

Failed to fetch results with details: bash: line 1: /opt/cloud/bin/filesystem_writable_check.py: Permission denied

Update: after making the file /opt/cloud/bin/filesystem_writable_check.py executable, the health check works fine.

[weizhouapache]

Failed to fetch results with details: bash: line 1: /opt/cloud/bin/filesystem_writable_check.py: Permission denied

Update: after making the file /opt/cloud/bin/filesystem_writable_check.py executable, the health check works fine.

@ccycv
did you replace the files in /opt/cloud/bin when you tested this PR ?
some files (including filesystem_writable_check.py) are not executable in source code, you can mark them all as executable

chmod +x /opt/cloud/bin/*

[ccycv]

Failed to fetch results with details: bash: line 1: /opt/cloud/bin/filesystem_writable_check.py: Permission denied
Update: after making the file /opt/cloud/bin/filesystem_writable_check.py executable, the health check works fine.

@ccycv did you replace the files in /opt/cloud/bin when you tested this PR ? some files (including filesystem_writable_check.py) are not executable in source code, you can mark them all as executable

chmod +x /opt/cloud/bin/*

I have only replaced the cloud-scripts.tgz on the management server and did the router rebuild.

[weizhouapache]

cloud-scripts.tgz

@ccycv
if you use maven to rebuild the tarball, the scripts in the tarball should be executable

mvn -P developer,systemvm clean install -pl systemvm/

[blueorangutan]

[SF] Trillian test result (tid-9982)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42891 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8741-t9982-kvm-centos7.zip
Smoke tests completed. 109 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_migrate_vm	Error	0.08	test_vm_life_cycle.py