Skip to content

UI: Fix upload SSL certificate failed in the project view - #4761

Merged
DaanHoogland merged 1 commit into
apache:4.15from
utchoang:feature/project-upload-ssl-certificate
Mar 9, 2021
Merged

DaanHoogland merged 1 commit into
apache:4.15from
utchoang:feature/project-upload-ssl-certificate

Conversation

@utchoang

@utchoang utchoang commented Mar 8, 2021 •

Copy link
Copy Markdown

Description

Fixes #4749

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@utchoang

utchoang commented Mar 8, 2021

Copy link
Copy Markdown
Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4761 (JID-3851)

@DaanHoogland DaanHoogland added this to the 4.15.1.0 milestone Mar 8, 2021

@DaanHoogland DaanHoogland left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, tested; upload works

@ravening

ravening commented Mar 9, 2021

Copy link
Copy Markdown
Member

LGTM and tested fine

@DaanHoogland
DaanHoogland merged commit 54853aa into apache:4.15 Mar 9, 2021
@utchoang
utchoang deleted the feature/project-upload-ssl-certificate branch March 10, 2021 00:41

@yadvr yadvr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants