Repository navigation
CLOUDSTACK-9683: system.vm.default.hypervisor will pin the hypervisor… - #1839
Merged
Merged
Conversation
… for VR too with this fix
Contributor
Author
|
@blueorangutan help |
|
@abhinandanprateek I understand these words: "help", "hello", "thanks", "package", "test" Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'jburwell', 'murali-reddy', 'abhinandanprateek', 'PaulAngus', 'borisstoyanov', 'karuturi'] |
Contributor
Author
|
@blueorangutan test centos6 kvm-centos6 |
|
@abhinandanprateek a Trillian-Jenkins test job (centos6 mgmt + kvm-centos6) has been kicked to run smoke tests |
Member
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-403 |
Contributor
Author
|
@blueorangutan test centos6 kvm-centos6 |
|
@abhinandanprateek a Trillian-Jenkins test job (centos6 mgmt + kvm-centos6) has been kicked to run smoke tests |
|
Trillian test result (tid-691)
|
borisstoyanov
approved these changes
Dec 21, 2016
Contributor
|
LGTM based on code review and test results, there seems to be no new test failures present. |
Member
|
@abhinandanprateek do we have a unit test or integration/smoke test to validate the global setting, or can you write one? |
Contributor
Author
|
@rhtyd most of the automation environments are single hypervisor one, so will end up creating a mixed hypervisor zone for this test only. If that can be done i can put one together, probably not worth the effort. @borisstoyanov |
Member
|
LGTM. Merging this now. |
asfgit
pushed a commit
that referenced
this pull request
Dec 22, 2016
CLOUDSTACK-9683: system.vm.default.hypervisor will pin the hypervisor for VR too with this fix * pr/1839: CLOUDSTACK-9683: system.vm.default.hypervisor will pin the hypervisor for VR too with this fix Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
borisstoyanov
left a comment
borisstoyanov
left a comment
Contributor
There was a problem hiding this comment.
LGTM, tested the changes and VR deployment is affected by this change now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… for VR too with this fix