packaging: use rng-tools service name on SUSE 15 - #14311
Open
kiranchavala wants to merge 2 commits into
Open
kiranchavala wants to merge 2 commits into
kiranchavala wants to merge 2 commits into
Conversation
On SUSE 15 the rng-tools package ships the service as rng-tools.service, not rngd.service, so enabling rngd silently failed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
kiranchavala
changed the title
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
Both substitutions match the SUSE service documented in the linked issue, with no blocking issues identified.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes SUSE 15 packaging so CloudStack installations enable and start the entropy daemon, addressing #14312.
Changes:
- Replaces
rngdwithrng-toolsin management and agent post-install scriptlets. - Preserves existing error handling.
| File | Description |
|---|---|
packaging/suse15/cloud.spec |
Corrects the entropy service name in both scriptlets. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14311 +/- ##
=========================================
Coverage 19.91% 19.91%
- Complexity 20175 20200 +25
=========================================
Files 6372 6373 +1
Lines 577139 577230 +91
Branches 70682 70696 +14
=========================================
+ Hits 114913 114952 +39
- Misses 449664 449712 +48
- Partials 12562 12566 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
@kiranchavala |
Member
Author
@weizhouapache not required with el8 and el9 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
this pr fixes #14312
On SUSE 15, the
rng-toolspackage provides the service asrng-tools.servicerather thanrngd.service. The management server and agent %post scriptlets inpackaging/suse15/cloud.spectried to enablerngd, which silently failed (output is discarded and|| trueis used), leaving the entropy daemon disabled.This changes both to:
Types of changes
How Has This Been Tested?
Packaging change only; install the management server and agent RPMs on SUSE 15 and verify
systemctl is-enabled rng-tools/systemctl is-active rng-tools.🤖 Generated with Claude Code