Repository navigation
Refactor: implement the managesnapshot.sh features via Java and remove the script #6424
Description
Activity
Hate to stand in the way of progress, but I believe part of the reason Cloudstack has shell scripts in various places, particularly in dealing with libvirt is because historically the java bindings have lagged behind in functionality etc.
With my Ops hat on, are we sure the shell script bits we want to replace with java are now properly supported in all the major distro, especially the older ones (eg CentOS 7, Ubuntu 20.04) or are we in danger of breaking upgrade paths?
Thoughts @weizhouapache @wido @rohityadavcloud ?Hate to stand in the way of progress, but I believe part of the reason Cloudstack has shell scripts in various places, particularly in dealing with libvirt is because historically the java bindings have lagged behind in functionality etc.
With my Ops hat on, are we sure the shell script bits we want to replace with java are now properly supported in all the major distro, especially the older ones (eg CentOS 7, Ubuntu 20.04) or are we in danger of breaking upgrade paths? Thoughts @weizhouapache @wido @rohityadavcloud ?
No, I actually think we should implement this in the Java bindings where possible, but ofcourse, caution is needed.
The reason things were implemented in shell scripts is because people didn't bother in implementing it in libvirt-java and thus just took the easier route.
Using the API calls of Libvirt is safer, has better Exception handling and such.
Where possible, use that :-)
Reacted by NuxRoHate to stand in the way of progress, but I believe part of the reason Cloudstack has shell scripts in various places, particularly in dealing with libvirt is because historically the java bindings have lagged behind in functionality etc.
With my Ops hat on, are we sure the shell script bits we want to replace with java are now properly supported in all the major distro, especially the older ones (eg CentOS 7, Ubuntu 20.04) or are we in danger of breaking upgrade paths? Thoughts @weizhouapache @wido @rohityadavcloud ?No, I actually think we should implement this in the Java bindings where possible, but ofcourse, caution is needed.
The reason things were implemented in shell scripts is because people didn't bother in implementing it in libvirt-java and thus just took the easier route.
Using the API calls of Libvirt is safer, has better Exception handling and such.
Where possible, use that :-)
agree with @wido
if we can do it using libvirt-java, it is much better.@GutoVeronezi are you working on this?
1 remaining item
@GutoVeronezi , given that much work on snapshots has been done since, what is the status of this ticket in your opinion?
This issue is stale because it has been open for 120 days with no activity. It may be removed by administrators of this project at any time. Remove the stale label or comment to request for removal of it to prevent this.
Several snapshot functionalities, in KVM, are implemented via the script
scripts/storage/qcow2/managesnapshot.sh. From #6422 (comment) came the idea to improve these processes by implementing the functionalities via Java, adding documentation, unit tests and logs.ISSUE TYPE
COMPONENT NAME
KVM