Repository navigation
test_privategw_acl.py failed in some Trillian tests #3859
Description
ISSUE TYPE
- Bug Report
COMPONENT NAME
VPC private gateway
CLOUDSTACK VERSION
4.14
CONFIGURATION
Advanced zone
OS / ENVIRONMENT
SUMMARY
Smoke test test_privategw_acl.py failed in some Trillian tests.
STEPS TO REPRODUCE
see more details in https://github.com/apache/cloudstack/blob/master/test/integration/smoke/test_privategw_acl.py#L317-L381
EXPECTED RESULTS
No errors/failures
ACTUAL RESULTS
Some tests failed. For example
https://github.com/apache/cloudstack/pull/3477#issuecomment-571288662
https://github.com/apache/cloudstack/pull/3836#issuecomment-579981259
https://github.com/apache/cloudstack/pull/3851#issuecomment-580891071
Activity
weizhouapache commentedon Feb 7, 2020
#3871 (comment)
weizhouapache commentedon Feb 11, 2020
#3601 (comment)
yadvr commentedon Feb 13, 2020
Failure seen in latest master smoketests - #3850 (comment)
@weizhouapache I see this issue, are you working on it?
weizhouapache commentedon Feb 13, 2020
@rhtyd yes
found the root cause: https://github.com/apache/cloudstack/blob/master/server/src/main/java/com/cloud/network/NetworkServiceImpl.java#L4472
private gateway in two VPCs use the same isolated network, if they have same vlan and cidr.
yadvr commentedon Feb 13, 2020
Okay @weizhouapache do we need to fix that in the test data config, test or in CloudStack java code?
yadvr commentedon Feb 18, 2020
@weizhouapache are you send a fix? Thanks.
weizhouapache commentedon Feb 18, 2020
@rhtyd we need to fix it in java code. it is not simple.
yadvr commentedon Feb 18, 2020
I think it is expected that vlan shouldn't be same? @weizhouapache - should we fix this in the test or test's config instead?
weizhouapache commentedon Feb 18, 2020
@rhtyd exactly. however in smoke test it creates two VPCs and private gateway with same vlan for each VPC, then test the connectivity between them. hence we have to add a new parameter bypassvlanoverlapcheck to private gateway so that the test can still go on.
yadvr commentedon Feb 20, 2020
@andrijapanicsb @DaanHoogland ^^ let's triage/assign this, could @Spaceman1984 pick this up?
Spaceman1984 commentedon Feb 20, 2020
I can take a look.
weizhouapache commentedon Feb 20, 2020
@rhtyd @Spaceman1984 I will create a PR today
Spaceman1984 commentedon Feb 20, 2020
ok, Thanks @weizhouapache
yadvr commentedon Feb 20, 2020
Great, thanks @weizhouapache