updatePod does not update start/end IPs #2797

Activity

1. resmo

   added

   type:bug

   component:api

   on Aug 10, 2018
2. kioie commented on Apr 23, 2019

   

   kioie

   on Apr 23, 2019

   Contributor

   More actions

   Is there a situation where a pod can have multiple IPs as shown below?

   // Check if start IP and end IP of all the ranges lie in the CIDR subnet.
           final String[] existingPodIpRanges = pod.getDescription().split(",");
   
           for(String podIpRange: existingPodIpRanges) {
               final String[] existingPodIpRange = podIpRange.split("-");
   
               if (existingPodIpRange.length > 1) {
                   if (!NetUtils.isValidIp4(existingPodIpRange[0]) || !NetUtils.isValidIp4(existingPodIpRange[1])) {
                       continue;
                   }
   
                   if (!NetUtils.getCidrSubNet(existingPodIpRange[0], cidrSize).equalsIgnoreCase(NetUtils.getCidrSubNet(cidrAddress, cidrSize))) {
                       throw new InvalidParameterValueException("The start address of the some IP range is not in the CIDR subnet.");
                   }
   
                   if (!NetUtils.getCidrSubNet(existingPodIpRange[1], cidrSize).equalsIgnoreCase(NetUtils.getCidrSubNet(cidrAddress, cidrSize))) {
                       throw new InvalidParameterValueException("The end address of the some IP range is not in the CIDR subnet.");
                   }
   
                   if (NetUtils.ipRangesOverlap(existingPodIpRange[0], existingPodIpRange[1], gateway, gateway)) {
                       throw new InvalidParameterValueException("The gateway shouldn't overlap some start/end ip addresses");
                   }
               }
           }
   

   Also, I'm curious as to why the pod start and end IP details are stored as a string in the description field? cc @DaanHoogland @rhtyd

   
3. kioie

   added 2 commits that reference this issue on Apr 23, 2019

   apache#2797

   ...

   bf00551

   apache#2797

   ...

   6419a17
4. yadvr

   added this to the 4.13.0.0 milestone on May 27, 2019
5. yadvr

   modified the milestones: 4.13.0.0, 4.13.1.0 on Jul 4, 2019
6. yadvr

   modified the milestones: 4.13.1.0, 4.14.0.0 on Dec 7, 2019
7. andrijapanicsb commented on Jan 3, 2020

   

   andrijapanicsb

   on Jan 3, 2020

   Contributor

   More actions

   Fixes for this issue are being done in PR #3292 - I'll close the issue here and let's continue the discussion in the PR.
8. andrijapanicsb

   closed this as completedon Jan 3, 2020