"Add VPC" Button does nothing if no Advanced Zone with securitygroupsenabled=false #2698

Activity

1. yadvr

   added this to the 4.11.1.0 milestone on Jun 7, 2018
2. yadvr commented on Jun 8, 2018

   

   yadvr

   on Jun 8, 2018

   Member

   More actions

   @DaanHoogland @PaulAngus can you advise/triage this?
3. DaanHoogland commented on Jun 8, 2018

   

   DaanHoogland

   on Jun 8, 2018

   Contributor

   More actions

   For my part this is a UI limitation and not a blocker for 4.11.1. If @cocoon leaves us with a patch I am happy to include it, though.
4. yadvr commented on Jun 8, 2018

   

   yadvr

   on Jun 8, 2018

   Member

   More actions

   @cocoon I've fixed the UI failure/issue in this PR: #2704
   However, note that VPC will not work with SG+Adv Zone.
   The create VPC form will show up with the fix in the above PR, but the list of zones will be empty (if all the zones have SG enabled).
5. cocoon commented on Jun 8, 2018

   

   cocoon

   on Jun 8, 2018

   Author

   More actions

   Great thanks, I was just working on something similar, it was still not a fix but it would at least display a Notice and not show the dialog and still throwing the error in the background.
   Because if it returns early and displays the Dialog, the Notification-Window is behind the setup dialog.

   var advZones = $.grep(zones, function(zone) {
                                                           return zone.networktype == 'Advanced' && !zone.securitygroupsenabled;
                                                       });
   
   
   //Validate that a valid zone was found or notify
   if (!Array.isArray(advZones) || !advZones.length) {
     cloudStack.dialog.notice({
       message: 'No valid Zone was found! Required: Advanced Zone with SecurityGroups disabled.'
     });
   }
   
6. PaulAngus

   closed this as completedon Jun 8, 2018