Windows passwords cannot be set or reset when the system is on an isolated network with dual routers #11877

problem

Using dual routers:
VIP IP: 10.90.0.1 (where password provider port 8080 is open)
Primary: 10.90.0.74
Secondary: 10.90.0.193

Error log
[ERROR]: Unable to contact password provider at: http://10.90.0.74:8080/

It's trying to use the local ip address from primary router. Port 8080 is not open on local ip addres 10.90.0.74

I figured out that windows is getting this ip from /etc/dnsmasq.d/cloud.conf:
listen-address= 127.0.0.1,10.90.0.1,10.90.0.74

If I change the listen-addres to: listen-address= 127.0.0.1,10.90.0.1 and restart dnsmasq, it works.

In VR /opt/cloud/bin/cs/CsDhcp.py:

if self.cl.is_redundant(): listen_address.append(gateway) listen_address.append(ip)

FIX:

if self.cl.is_redundant(): listen_address.append(gateway) else: listen_address.append(ip)

versions

Cloudstack 4.21.0.0 + Vmware 8u3g

The steps to reproduce the bug

Create a new windows machine or try to reset it's password

What to do about it?

I figured out that windows is getting this ip from /etc/dnsmasq.d/cloud.conf:
listen-address= 127.0.0.1,10.90.0.1,10.90.0.74

If I change the listen-addres to: listen-address= 127.0.0.1,10.90.0.1 and restart dnsmasq, it works.

In VR /opt/cloud/bin/cs/CsDhcp.py:

if self.cl.is_redundant(): listen_address.append(gateway) listen_address.append(ip)

FIX:

if self.cl.is_redundant(): listen_address.append(gateway) else: listen_address.append(ip)