Repository navigation
Two API requests done towards api.github.com anytime someone visits ACS UI #10522
Description
problem
Anytime anyone visit our cloudstack webui you get two notifications in top right corner saying:
Forbidden
API rate limit exceeded for REDACTED_IP. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)
It does not matter if you are logged in our not. It's because for some reason my browser do two API requests towards Github.
versions
ACS: 4.20.0
The steps to reproduce the bug
- Visit the webui
- Open browser console
- F5
- Two API requests towards Github is made to https://api.github.com/repos/apache/cloudstack/releases
What to do about it?
Can this behavior be disabled somehow?
Activity
[-]Two API requests done towards api.github.com anytime i someone visits ACS UI[/-][+]Two API requests done towards api.github.com anytime someone visits ACS UI[/+]DaanHoogland commentedon Mar 7, 2025
@Sparc0 , I see only one call, but that IMNSHO is one too many. I will look into the functionality requiring this and into disabling this by default.
DaanHoogland commentedon Mar 7, 2025
@Sparc0 the reason you might see two calls to api.github is because you have oauth enabled, is that true?
Sparc0 commentedon Mar 7, 2025
I dont use oauth.
This is a complete fresh and new mgmt server installed and i was met by the error on first login.
Since it does it towards https://api.github.com/repos/apache/cloudstack/releases does the UI check i run the latest version or something?
DaanHoogland commentedon Mar 7, 2025
@Sparc0 , another question, you should only get this when you log on as "Root Admin". Are you saying you get it as any user?
Yes, it should tell you if there is a newer version.
Sparc0 commentedon Mar 7, 2025
We only have one user at the moment, have not setup LDAP or any other local users yet. I could try that next week see if that helps.
DaanHoogland commentedon Mar 9, 2025
@Sparc0 , I created a PR that would reduce the double call to api.github, but I could not reproduce that part, so it is purely theoratical. Can you try #10533 ?
Sparc0 commentedon Mar 10, 2025
Sure, do you want me to clone your PR and build it using this instructions?
OR is the EL9 packages that blue mentions here available somewhere?
DaanHoogland commentedon Mar 10, 2025
The packages are in a private lab to be used for integration tests. If you can build, please do. If all else fails we can arrange some file transfer.
DaanHoogland commentedon Apr 7, 2025
@Sparc0 , did you manage to test?
Sparc0 commentedon Apr 7, 2025
Not yet, have been occupied with other things.
sureshanaparti commentedon Apr 14, 2025
@Sparc0 I couldn't reproduce this (https://api.github.com/repos/apache/cloudstack/releases called once during login), Can you verify with PR #10533?
Sparc0 commentedon Apr 26, 2025
I still have not had time to compile and test.
@sureshanaparti i guess your IP you are behind is not getting rate limited by Github thats why you only call it once and also get no notification because it works.
I work on a very huge tech company, and probably why one of our IPs i get NATed to is rate limited by Github. And maybe why it tries to do two API calls because the first one fails.
But as Daan wrote in a earlier comment that one is even too many.
I tried login on the UI build for 10533, but i got the warning again. only once, not twice.
weizhouapache commentedon Oct 8, 2025
fixed by #10533