This repository was archived by the owner on Jan 20, 2021. It is now read-only.
Repository navigation
view: notify admin to restart MS for non-dynamic settings - #290
Merged
Merged
Conversation
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
yadvr
reviewed
Apr 14, 2020
| message: 'Status', | ||
| description: 'Please restart your management server(s) for your new settings to take effect.' | ||
| }) | ||
| if (json.updateconfigurationresponse && |
Member
There was a problem hiding this comment.
@shwstppr would this work if API doesnot have the isdynamic in the API response?
Contributor
Author
There was a problem hiding this comment.
@rhtyd should be okay with !json.updateconfigurationresponse.configuration.isdynamic &&
yadvr
approved these changes
Apr 17, 2020
weizhouapache
pushed a commit
that referenced
this pull request
Jan 19, 2021
) Fixes #83 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #83