Repository navigation
Don't charge aggregate costs to the DQA dedup HashAggregates - #2261
Open
chenjinbao1989 wants to merge 1 commit into
Open
chenjinbao1989 wants to merge 1 commit into
chenjinbao1989 wants to merge 1 commit into
Conversation
In add_multi_dqas_hash_agg_path(), the HashAggregates that remove duplicates after the TupleSplit only deduplicate their input; they do not run any aggregate transition or final functions. But DedupCost was filled by get_agg_clause_costs() before they were created, so they were charged the costs of all aggregates in the query. Move the call after them, so the dedup aggregates are costed with empty aggregate costs.
Contributor
|
Thanks for fixing it and clean up FIXMEs, and some comments below:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In add_multi_dqas_hash_agg_path(), the HashAggregates that remove duplicates after the TupleSplit only deduplicate their input; they do not run any aggregate transition or final functions. But DedupCost was filled by get_agg_clause_costs() before they were created, so they were charged the costs of all aggregates in the query. Move the call after them, so the dedup aggregates are costed with empty aggregate costs.
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions