Repository navigation
Conversation
The test steps join make_configs with spaces and then split the result on spaces. An entry that contains a space, such as "dir:all installcheck", becomes two configurations, and the second one has no directory. Join the entries with newlines and read one entry per line instead. All current entries give the same configurations as before. apache#2237 has the same change. Assisted-by: Claude Code
CI does not run the TAP tests in src/test/modules/libpq_pipeline, so nobody sees when the libpq pipeline mode breaks. Add an ic-libpq-pipeline test job that runs them on Rocky 8, 9 and 10. The test program is not installed (NO_INSTALL), and installcheck does not build it, so run "all installcheck". Assisted-by: Claude Code
Since the REL_16_9 merge, CREATE UNLOGGED TABLE fails when the table has a serial or identity column: CREATE UNLOGGED TABLE t (id serial, b text); ERROR: unlogged sequences are not supported PostgreSQL 15 added unlogged sequences, and an identity or serial sequence now gets the persistence of its table (upstream commit 344d62f). The merge took that change, but kept the check in DefineSequence() that rejects unlogged sequences, because Cloudberry does not support them. So an unlogged table can no longer have a serial or identity column. Before the merge, its sequence was logged and the table was created. The libpq_pipeline test fails because of this, and several regression tests expect the error. Create the sequence of an unlogged table as a logged sequence, as before PostgreSQL 15. For the same reason, ALTER TABLE ... SET UNLOGGED does not change the owned sequences of the table any more. An explicit UNLOGGED option for the sequence still gets the error. Update the expected output of identity, alter_table and spgist, and of the pax and singlenode copies, which now show the created tables and the logged sequences. Assisted-by: Claude Code
leborchuk
reviewed
Nov 6, 2026
| else if (seqpersistence == RELPERSISTENCE_UNLOGGED) | ||
| { | ||
| /* | ||
| * Cloudberry does not support unlogged sequences. So the sequence of |
Contributor
There was a problem hiding this comment.
Do we really not support unlogged sequences or it's just a rebasing mistake?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions