Repository navigation
Conversation
CI does not run the TAP tests in src/bin/scripts, so nobody sees when createdb, dropdb, clusterdb, reindexdb, vacuumdb and the other client programs break. Add an ic-scripts test job that runs them on Rocky 8, 9 and 10. Assisted-by: Claude Code
Five test files in src/bin/scripts fail on Cloudberry: - 011_clusterdb_all, 050_dropdb, 091_reindexdb_all and 101_vacuumdb_all mark a database as invalid with an UPDATE of pg_database. Cloudberry does not allow DML on a system catalog without allow_system_table_mods, so each test stops with "permission denied: "pg_database" is a system catalog". Set the parameter before the UPDATE, as 037_invalid_database in src/test/recovery does. - In 090_reindexdb, PostgreSQL 16 adds --concurrently to the tablespace checks and to the parallel database check. Cloudberry does not support REINDEX CONCURRENTLY, and reindexdb fails with "reindexing a database concurrently is not supported". Skip these checks, as the file already does for the other --concurrently checks. The checks without --concurrently that run before them still test the same tablespace behavior. Assisted-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI does not run the TAP tests in src/bin/scripts, so nobody sees when createdb, dropdb, clusterdb, reindexdb, vacuumdb and the other client programs break.
Add an ic-scripts test job that runs them on Rocky 8, 9 and 10.
Assisted-by: Claude Code
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions