Repository navigation
Conversation
CI does not run the TAP tests in src/bin/pgbench, so nobody sees when pgbench breaks. Add an ic-pgbench test job that runs them on Rocky 8, 9 and 10. Assisted-by: Claude Code
The REL_16_9 merge moved the handler of the Cloudberry option --use-non-unique-keys to case 16, because PostgreSQL 15 added --failures-detailed with code 13. But the long option entry still has code 13. So --use-non-unique-keys does the same as --failures-detailed: - With -i, pgbench fails with "some of the specified options cannot be used in initialization (-i) mode", and does not create the tables. - Without -i, the option enables detailed failure reports, and the keys stay unique. Give the option code 16, the same as its handler. Assisted-by: Claude Code
leborchuk
approved these changes
Nov 6, 2026
leborchuk
left a comment
leborchuk
left a comment
Contributor
There was a problem hiding this comment.
LGTM, well, let's test pgbench too )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI does not run the TAP tests in src/bin/pgbench, so nobody sees when pgbench breaks.
Add an ic-pgbench test job that runs them on Rocky 8, 9 and 10.
Assisted-by: Claude Code
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions