Repository navigation
Ci read test results - #2252
Open
Vlasdislav wants to merge 3 commits into
Open
Ci read test results#2252Vlasdislav wants to merge 3 commits into
Vlasdislav wants to merge 3 commits into
Conversation
Vlasdislav
requested review from
edespino,
leborchuk and
tuhaihe
and removed request for
leborchuk and
tuhaihe
November 5, 2026 10:16
leborchuk
reviewed
Nov 6, 2026
| if [ ! -f "$config_log" ]; then | ||
| { | ||
| echo "MAKE_COMMAND=\"${behave_cmd}\"" | ||
| echo "MAKE_COMMAND=${behave_cmd}" |
Contributor
There was a problem hiding this comment.
Could we keep the "" quotes while printing command? Why we change it, let quotes be printed out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
For example I see in job Generate Test Job Summary End: ic-pl-modules output:
This because we sourcing command at time reading after end tests.
Solving
Read test result files as data instead of sourcing them as shell scripts. This prevents values such as
install installcheckfrom being interpreted as commands when generating CI summaries.